Skip to content

On Planet: Link to Blog itself #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

On Planet: Link to Blog itself #1560

wants to merge 3 commits into from

Conversation

guptadiksha307
Copy link
Contributor

@guptadiksha307 guptadiksha307 commented Apr 25, 2021 •
edited
Loading

Issue Description

Fixes #1529

Changes Made

On the right of the planet page (Home -> Community -> OCaml Planet) there is a list of blogs. Clicking on one of them opens the rss rather than the blog itself. I have added a link to the blog itself so that if one of the blogs is clicked, then the main page of the blog opens up.

image

Please check if the PR fulfills these requirements

  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@guptadiksha307
Copy link
Contributor Author

Talking about the code structure, firstly I built a function get_blog_feeds that gave me list of tuples like [("name1","url1"); ("name2","url2");(..)] then I sorted this list according to name and then I changed this list as [("href","url1"); ("href","url2");(..)] then I iterated over this list to get first element [("href","url1")] and added this list as an attribute to a element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On planet: link to blog itself
1 participant
@guptadiksha307